Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Unable to disable watch and output folders from mounting #328

Open
shanelord01 opened this issue Feb 16, 2024 · 3 comments
Open

[Bug] Unable to disable watch and output folders from mounting #328

shanelord01 opened this issue Feb 16, 2024 · 3 comments
Labels

Comments

@shanelord01
Copy link

Current Behavior

I have these disabled in my docker-compose:

-v /home/user/HandBrake/watch:/watch:rw \

-v /home/user/HandBrake/output:/output:rw \

and put AUTOMATED_CONVERSION=0 in my environment

but these directories are still being mounted as non persistent volumes

Expected Behavior

Don't create mounts for them if automated conversion is disabled and they are not required

Steps To Reproduce

comment out the volumes and set AUTOMATED_CONVERSION=0

You will see docker create non persistent volumes for these.

Environment

  • OS:
  • OS version:
  • CPU:
  • Docker version:
  • Device model:
  • Browser/OS:

Container creation

version: '3'
services:
handbrake:
image: jlesage/handbrake:latest
ports:
- 5800:5800
volumes:
- handbrake_config:/config
- video_nfs:/storage

deploy:
  resources:
    reservations:
      devices:
        - capabilities: [gpu]
environment:
  - TZ=Australia/Sydney
  - AUTOMATED_CONVERSION=0
restart: unless-stopped
devices:
  - /dev/dri:/dev/dri

volumes:
handbrake_config:
external: true
video_nfs:
external: true

Container log

n/a

Container inspect

No response

Anything else?

No response

@jlesage
Copy link
Owner

jlesage commented Feb 16, 2024

This is a behaviour of Docker: these volumes are created because /watch and /output folders are declared in the Dockerfile. If a mapping is not explicitly set, Docker will use a temporary volume.

@shanelord01
Copy link
Author

shanelord01 commented Feb 16, 2024

Thanks. Is there Any way to make them optional and become disabled if the AUTOMATED_CONVERSION=0 is set?

@jlesage
Copy link
Owner

jlesage commented Feb 17, 2024

Not to my knowledge. Volumes creation is not controlled by the container itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants