AUTOMATED_CONVERSION_FORMAT overrides preset #322
Labels
Comments
|
I wanted to add that I ran into this bug as well. My preset has MKV and the output is being overridden by the default value of docker-compose.ymlservices:
handbrake:
image: docker.io/jlesage/handbrake
container_name: handbrake
environment:
- USER_ID=444
- GROUP_ID=996
- SUP_GROUP_IDS=106
- UMASK=000
- DISPLAY_WIDTH=1280
- DISPLAY_HEIGHT=720
- TZ=America/New_York
- AUTOMATED_CONVERSION_PRESET=H265 4K
- AUTOMATED_CONVERSION_FORMAT=mkv
group_add:
- "106"
ports:
- "5800:5800"
volumes:
- "/handbrake/config:/config:rw"
- "/handbrake/output:/output:rw"
- "/handbrake/storage:/storage:rw"
- "/handbrake/trash:/trash:rw"
- "/handbrake/watch_1:/watch:rw"
devices:
- "/dev/dri/renderD128:/dev/dri/renderD128"
restart: alwayspreset.json{
"PresetList": [
{
"AlignAVStart": false,
"AudioCopyMask": [
"copy:mp2",
"copy:mp3",
"copy:aac",
"copy:ac3",
"copy:dts",
"copy:dtshd",
"copy:eac3",
"copy:flac",
"copy:truehd",
"copy:opus"
],
"AudioEncoderFallback": "none",
"AudioLanguageList": [
"eng"
],
"AudioList": [
{
"AudioBitrate": 6144,
"AudioCompressionLevel": 0,
"AudioEncoder": "copy",
"AudioMixdown": "5point1",
"AudioNormalizeMixLevel": false,
"AudioSamplerate": "auto",
"AudioTrackQualityEnable": false,
"AudioTrackQuality": 3,
"AudioTrackGainSlider": 0,
"AudioTrackDRCSlider": 0
},
{
"AudioBitrate": 256,
"AudioCompressionLevel": 0,
"AudioEncoder": "ac3",
"AudioMixdown": "stereo",
"AudioNormalizeMixLevel": false,
"AudioSamplerate": "auto",
"AudioTrackQualityEnable": false,
"AudioTrackQuality": 3,
"AudioTrackGainSlider": 0,
"AudioTrackDRCSlider": 0
}
],
"AudioSecondaryEncoderMode": true,
"AudioTrackSelectionBehavior": "all",
"ChapterMarkers": true,
"ChildrenArray": [],
"Default": true,
"FileFormat": "av_mkv",
"Folder": false,
"FolderOpen": false,
"Optimize": false,
"Mp4iPodCompatible": false,
"PictureCropMode": 0,
"PictureBottomCrop": 140,
"PictureLeftCrop": 0,
"PictureRightCrop": 0,
"PictureTopCrop": 140,
"PictureDARWidth": 1920,
"PictureDeblockPreset": "off",
"PictureDeblockTune": "medium",
"PictureDeblockCustom": "strength=strong:thresh=20:blocksize=8",
"PictureDeinterlaceFilter": "decomb",
"PictureCombDetectPreset": "default",
"PictureCombDetectCustom": "",
"PictureDeinterlacePreset": "default",
"PictureDeinterlaceCustom": "",
"PictureDenoiseCustom": "",
"PictureDenoiseFilter": "off",
"PictureSharpenCustom": "",
"PictureSharpenFilter": "off",
"PictureSharpenPreset": "medium",
"PictureSharpenTune": "none",
"PictureDetelecine": "off",
"PictureDetelecineCustom": "",
"PictureColorspacePreset": "off",
"PictureColorspaceCustom": "",
"PictureChromaSmoothPreset": "off",
"PictureChromaSmoothTune": "none",
"PictureChromaSmoothCustom": "",
"PictureItuPAR": false,
"PictureKeepRatio": true,
"PicturePAR": "auto",
"PicturePARWidth": 1,
"PicturePARHeight": 1,
"PictureWidth": 3840,
"PictureHeight": 2160,
"PictureUseMaximumSize": true,
"PictureAllowUpscaling": false,
"PictureForceHeight": 0,
"PictureForceWidth": 0,
"PicturePadMode": "none",
"PicturePadTop": 0,
"PicturePadBottom": 0,
"PicturePadLeft": 0,
"PicturePadRight": 0,
"PicturePadColor": "black",
"PresetName": "H265 4K",
"Type": 1,
"SubtitleAddCC": true,
"SubtitleAddForeignAudioSearch": true,
"SubtitleAddForeignAudioSubtitle": false,
"SubtitleBurnBehavior": "foreign",
"SubtitleBurnBDSub": false,
"SubtitleBurnDVDSub": false,
"SubtitleLanguageList": [
"eng"
],
"SubtitleTrackSelectionBehavior": "all",
"VideoAvgBitrate": 0,
"VideoColorMatrixCode": 0,
"VideoEncoder": "x265_10bit",
"VideoFramerateMode": "vfr",
"VideoGrayScale": false,
"VideoScaler": "swscale",
"VideoPreset": "slow",
"VideoTune": "",
"VideoProfile": "main10",
"VideoLevel": "auto",
"VideoOptionExtra": "strong-intra-smoothing=0:rect=0:aq-mode=1:rd=4:psy-rd=0.75:psy-rdoq=4.0:rdoq-level=1:rskip=2",
"VideoQualityType": 2,
"VideoQualitySlider": 12,
"VideoMultiPass": true,
"VideoTurboMultiPass": false,
"x264UseAdvancedOptions": false,
"PresetDisabled": false,
"MetadataPassthrough": true
}
],
"VersionMajor": 53,
"VersionMicro": 0,
"VersionMinor": 0
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
I've been using this project for a while now encoding dvd rips to mp4 files on my media server, but now I need to start ripping blu-rays to mkv files (to preserve subtitles) I've run into an issue. It looks like the AUTOMATED_CONVERSION_FORMAT env variable is overwriting the setting in the preset, which is quite an unintuitive way of handling things.
Adding AUTOMATED_CONVERSION_FORMAT=mkv to the compose file results in mkv output files, but then my presets set to create mp4 output files also produce mkv files. I'd like to be able to output difference video file types when using different presets, rather than locking that container to only handling one output file type. Is there an option for this that will use the setting in the preset, like how the SAME_AS_SRC setting for AUTOMATED_CONVERSION_OUTPUT_SUBDIR mirrors the subdirectory of the input files? I tried setting AUTOMATED_CONVERSION_FORMAT=SAME_AS_PRESET, but that just got me a file ending in .SAME_AS_PRESET
Expected Behavior
Output file type selected in preset should be used.
Steps To Reproduce
No response
Environment
`Client: Docker Engine - Community
Version: 25.0.1
API version: 1.44
Go version: go1.21.6
Git commit: 29cf629
Built: Tue Jan 23 23:09:52 2024
OS/Arch: linux/amd64
Context: default
Server: Docker Engine - Community
Engine:
Version: 25.0.1
API version: 1.44 (minimum version 1.24)
Go version: go1.21.6
Git commit: 71fa3ab
Built: Tue Jan 23 23:09:52 2024
OS/Arch: linux/amd64
Experimental: false
containerd:
Version: 1.6.27
GitCommit: a1496014c916f9e62104b33d1bb5bd03b0858e59
runc:
Version: 1.1.11
GitCommit: v1.1.11-0-g4bccb38
docker-init:
Version: 0.19.0
GitCommit: de40ad0
`
Container creation
Compose file:
`---
https://github.com/jlesage/docker-handbrake
version: '3'
services:
handbrake:
image: jlesage/handbrake
ports:
- "5800:5800"
volumes:
- "./config:/config:rw"
- "CHANGE_TO_COMPOSE_DATA_PATH/Storage:/storage:rw"
- "CHANGE_TO_COMPOSE_DATA_PATH/In/720p-slow-20:/watch:rw"
- "CHANGE_TO_COMPOSE_DATA_PATH/In/720p-med-22:/watch2:rw"
- "CHANGE_TO_COMPOSE_DATA_PATH/In/1080p-slow-22:/watch3:rw"
- "CHANGE_TO_COMPOSE_DATA_PATH/In/1080p-med-24:/watch4:rw"
- "CHANGE_TO_COMPOSE_DATA_PATH/In/4k-slow-25:/watch5:rw"
- "CHANGE_TO_COMPOSE_DATA_PATH/Out:/output:rw"
environment:
- AUTOMATED_CONVERSION_PRESET=Custom/720p-H265-20-slow
- AUTOMATED_CONVERSION_PRESET_2=Custom/720p-H265-22-med
- AUTOMATED_CONVERSION_PRESET_3=Custom/1080p-H265-22-slow-mkv
- AUTOMATED_CONVERSION_PRESET_4=Custom/1080p-H265-24-med-mkv
- AUTOMATED_CONVERSION_PRESET_5=Custom/4k-H265-25-slow-mkv
- AUTOMATED_CONVERSION_KEEP_SOURCE=0
- AUTOMATED_CONVERSION_OUTPUT_SUBDIR=SAME_AS_SRC
- AUTOMATED_CONVERSION_NON_VIDEO_FILE_ACTION=copy
deploy:
resources:
limits:
cpus: "12"
memory: 16g
`
Container log
Container inspect
Anything else?
No response
The text was updated successfully, but these errors were encountered: