-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Minification Problem #28
Comments
@jleeson FYI |
Thank you, I will work on a solution to the minifier this week. |
You can use my project as a demo if you need to playground it. Branch: revert-202-revert-201-upgrade-rollup-plugin-import-css Launch: npm run dev |
@rez1dent3, I have updated the minifyCSS function to properly strip whitespace without breaking the styling rules. Give v3.5.3 a try and let me know if that resolves it for you. |
Expectation: https://bavix.github.io/uuid-ui/ |
I thought my test covered all use cases, but it appears I thought wrong. Sorry for the inconvenience, I will work on a better fix today. |
@rez1dent3 can you please update to v3.5.4 and let me know if that solves the problem? I implemented a new minifer from scratch instead of trying to modify the original implementation which was broken in several ways. I have tested this version in the branch you listed for your project and it is matching the expected result you outlined. |
Yes, this solved my problem. Thank you. |
Hello. When I said that the problem was in the plugin @babel/plugin-syntax-import-attributes, I simply forgot to update your package. I checked on version 3.5.1 :there should be a picture of harold here:
Revert revert: bavix/uuid-ui#203
My imports:
diff: https://www.diffchecker.com/ck0onuCe/
Was / became:
Originally posted by @rez1dent3 in #27 (comment)
The text was updated successfully, but these errors were encountered: