Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut Meshes: Fixes for SRD #181

Open
cgt3 opened this issue Aug 30, 2024 · 0 comments
Open

Cut Meshes: Fixes for SRD #181

cgt3 opened this issue Aug 30, 2024 · 0 comments

Comments

@cgt3
Copy link
Collaborator

cgt3 commented Aug 30, 2024

There are two issues with the SRD code. See code in the file src/state_redistribution.jl in branch cgt3-thesis-edits-recovery for the necessary fixes.

  1. The logic in the parts of the SRD code is flipped. This is not an issue for meshes where cut elements can be stabilized by merging with a single neighbor (this was true of all our previous cut meshes) but will cause issues when this is not the case.

  2. The data layout needed for Trixi fluxes was not compatible with our original SRD code due to a type issue. The above code also provides a fix (see lines of code dealing with array_type). This is a breaking change for codes that previously used SRD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant