Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cronjob should have escape signs for % #66

Open
AtzeDeVries opened this issue Jan 4, 2016 · 5 comments
Open

cronjob should have escape signs for % #66

AtzeDeVries opened this issue Jan 4, 2016 · 5 comments

Comments

@AtzeDeVries
Copy link

OS: Ubuntu 14.04
The curator jobs are created by the puppet module are like this.
/usr/local/bin/curator --master-only --host <removed> --port 9200 --logfile /var/log/curator.log --loglevel INFO --logformat default delete indices --prefix '<removed>' --time-unit days --older-than 5 --timestring '%Y.%m.%d'

The cronjob is not working. The % should be escaped like this: --timestring '\%Y.\%m.\%d'

more info:
elastic/curator#151 (comment)

@AtzeDeVries
Copy link
Author

i see that this is fixed in the master branch but there is no tag attached to this change.

We generaly only use tagged checkouts of modules since this is the only way to ensure unwanted code changes. Is it possible to release a 2.0.2 for this?

@RehanSaeed
Copy link

+1 I was scratching my head until I read this.

@jlambert121
Copy link
Owner

I believe this is the same as #56. I'll be honest - I'm not quite sure which is correct. :)

@thenom
Copy link

thenom commented Jul 5, 2016

It think the timestring should be '%Y.%m.%d' to make sure that the escape character appears in cron.

I have set this up in hiera and applied for tomorrow mornings jobs and will report back.

@thenom
Copy link

thenom commented Jul 6, 2016

Just confirm, this is my working hiera for the timestring:

timestring: "\%Y.\%m.\%d"

The cron jobs ran without issues this morning. I was supposed to have double backslashes to turn off the escape character in the previous comment but didn't notice that github had escaped it out :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants