From 2aaf6cc3c9fda40f8be16d62c3b0d2f892e5db78 Mon Sep 17 00:00:00 2001 From: Yuya Nishihara Date: Sat, 21 Dec 2024 11:30:32 +0900 Subject: [PATCH] cli: remove now redundant dunce::simplified() from run_ui_editor() The tests still use dunce::simplified() so we won't reintroduce the problem. --- cli/src/cli_util.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/cli/src/cli_util.rs b/cli/src/cli_util.rs index 7c2ca9da1d..1c8980dfe8 100644 --- a/cli/src/cli_util.rs +++ b/cli/src/cli_util.rs @@ -2852,9 +2852,6 @@ impl LogContentFormat { } pub fn run_ui_editor(settings: &UserSettings, edit_path: &Path) -> Result<(), CommandError> { - // Work around UNC paths not being well supported on Windows (no-op for - // non-Windows): https://github.com/jj-vcs/jj/issues/3986 - let edit_path = dunce::simplified(edit_path); let editor: CommandNameAndArgs = settings.get("ui.editor")?; let mut cmd = editor.to_command(); cmd.arg(edit_path);