Clarify which Chrome extension this setting is referring to

[dandv]

I'm new to Jitsi and technical enough to have figured out the config file in which I could change some UI settings. Yet this one is unclear:

/**
    * Decides whether the chrome extension banner should be rendered on the landing page and during the meeting.
    * If this is set to false, the banner will not be rendered at all. If set to true, the check for extension(s)
    * being already installed is done before rendering.
    */
    SHOW_CHROME_EXTENSION_BANNER: false,

What extension is that?

[jhiswin]

It's this one:

Doesn't really need clarifying, since it's the only one.

[dandv]

Doesn't really need clarifying, since it's the only one.

Interesting, what made you think I knew there was any extension at all?

[jhiswin]

Not to tell you what you should or shouldn't know, but it says "Chrome Extension". There's only the one Jitsi Chrome Extension. You either click the banner, or go to the Chrome Store. It's not exactly rocket science.
I (personally) don't really see any reason they need to clarify this.
Maybe if this were a paid product with paid support, where they need to provide you guided support and accountability to your average IT support staff or simple user. Providing videos and training or whatever it is their paid patreons need, so that they don't get chewed out by their superiors.

[dandv]

I'm not sure you we have the same understanding of how open source works.

Rather than arguing what "they" should do, I've chosen to contribute instead. Feel free to disagree on that PR, or further contribute, such as by,

1. Explaining why the setting is still relevant for self-hosted installs, given that the extension clearly states

   This extension provides calendar integrations to schedule meetings for meet.jit.si[sic] site.

2. Explaining why the comment for that setting refers to a plural: "the check for extension(s) being already installed..."

There's only the one Jitsi Chrome Extension.

A Google search for "Jitsi Chrome extension" shows three results. Fortunately, only one is published by Jit.si.

You either click the banner, or go to the Chrome Store. It's not exactly rocket science.

What banner? The setting is false by default. The problem I've reported in this issue occurs when a user self-hosts Jitsi Meet and looks at the settings in interface_config.js.

[damencho]

2. Explaining why the comment for that setting refers to a plural: "the check for extension(s) being already installed..."

https://github.com/jitsi/jitsi-meet/blob/master/config.js#L419

There can be multiple extensions to check, there are deployments using several extensions and that checks all listed in the config.

[jhiswin]

Handbook Docs are a little bit lacking. Which is probably where these things should go:
https://github.com/jitsi/handbook

I think that's the right place for the full Jitsi docs including the self-hosting instructions?
Someone good at writing docs could (should) make some updates over there.

[dandv]

I think that's the right place for the full Jitsi docs including the self-hosting instructions?

Agree, but on the other hand, https://github.com/jitsi/jitsi-meet/blob/master/config.js is thoroughly commented inline, probably for good reasons. Do those apply to interface_config.js?

[saghul]

Here is where the config for that banner is taken from:

jitsi-meet/config.js

Line 419 in b4ecef4

// chromeExtensionBanner: {

I agree that for those who have been around the block for a while this might be confusing, as an extension was needed in the past for screen-sharing. This hasn't been the case for a long time now though.

[saghul]

Superseded by #7172