Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing packages on generate #3

Closed
iain17 opened this issue Sep 15, 2017 · 3 comments
Closed

Missing packages on generate #3

iain17 opened this issue Sep 15, 2017 · 3 comments

Comments

@iain17
Copy link

iain17 commented Sep 15, 2017

When I run go generate ./... using the latest master code. I get a file called autogenerated_***.go just like the readme states it should. The problem is that it is importing a package called base "github.com/jirfag/go-queryset/queryset/base" which doesn't seem to exist.

It also misses the packages "time" and "fmt"

Any ideas?

@iain17 iain17 changed the title github.com/jirfag/go-queryset/queryset/base Missing packages on generate Sep 15, 2017
@iain17
Copy link
Author

iain17 commented Sep 15, 2017

Found the perpetrator:

const hdrTmpl = `package %s

I'm just wondering why these packages?

@jirfag
Copy link
Owner

jirfag commented Sep 15, 2017

Thank you for this report!
Just fixed bad import of github.com/jirfag/go-queryset/queryset/base. It worked for me because goimports siliently removed it.

I've fixed bad import in master branch.
Also I will try to fix missing goimports, using it from vendor.

@jirfag
Copy link
Owner

jirfag commented Sep 19, 2017

Now goimports isn't needed: we use goimports source code and call it directly

@jirfag jirfag closed this as completed Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants