Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Performance issue #9

Open
lars18th opened this issue Aug 29, 2017 · 2 comments
Open

[BUG] Performance issue #9

lars18th opened this issue Aug 29, 2017 · 2 comments
Labels
Milestone

Comments

@lars18th
Copy link

Hi,

With the last release (v0.0.1-Beta3) when errors appear in the console (using WARN debug) then the CPU goes up to 100%.

I suggest to close the thread/tunnel/connection when a fatal error appears in the protocol (that is not when a simple error in the messages appears, but when is connection fails).

Here the client log when the CPU is at 100%:

ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1441, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1439, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1441, dropped.
ERRO[23136] CM: Connection didn't exist, client id: 2594778617, connection id: 1440, dropped.
ERRO[23144] CM: Connection didn't exist, client id: 2594778617, connection id: 1326, dropped.
ERRO[23177] CM: Connection didn't exist, client id: 2594778617, connection id: 1403, dropped.
ERRO[23177] CM: Connection didn't exist, client id: 2594778617, connection id: 1404, dropped.
ERRO[23180] CM: Connection didn't exist, client id: 2594778617, connection id: 1408, dropped.
ERRO[23190] CM: Connection didn't exist, client id: 2594778617, connection id: 1327, dropped.
ERRO[23190] CM: Connection didn't exist, client id: 2594778617, connection id: 1328, dropped.
ERRO[23386] CM: Connection didn't exist, client id: 2594778617, connection id: 1443, dropped.
ERRO[23389] CM: Connection didn't exist, client id: 2594778617, connection id: 1324, dropped.
ERRO[23477] CM: Connection didn't exist, client id: 2594778617, connection id: 1448, dropped.
ERRO[23483] CM: Connection didn't exist, client id: 2594778617, connection id: 1445, dropped.
ERRO[23483] CM: Connection didn't exist, client id: 2594778617, connection id: 1446, dropped.
ERRO[23686] CM: Connection didn't exist, client id: 2594778617, connection id: 1450, dropped.
ERRO[24169] CM: Connection didn't exist, client id: 2594778617, connection id: 1256, dropped.

I hope this helps.

@jim3ma jim3ma added the bug label Aug 30, 2017
@jim3ma jim3ma added this to the 0.0.1 milestone Aug 30, 2017
@jim3ma
Copy link
Owner

jim3ma commented Aug 30, 2017

I can not reproduce those error.

Can you provide the debug log?

Many thanks!

@lars18th
Copy link
Author

Hi @jim3ma ,

This is the full log (warn level) over the last lines... Two comments:

  1. This is with the last release, so if you use the last commit perhaps the problem is solved.

  2. These messages appear when the client initiates a lot of connections (is a web proxy), and when some of these connections are killed (not closed)... Or this is I think! When I use only one connection (for example with a SSH tunnel over the gota multi-link) I don't see any trouble. Even if I redirect the same proxy connection over the SSH tunnel. So, I imagine that the trouble is with not-well-closed sockets.

In any case, I can prepare a more extensive log.
However, please, I suggest that you implement the function #8. This will simplifies the testing as I can tunnel two sockets: one to the webserver and one to the SSH server.

Thanks to you!

@lars18th lars18th changed the title BUG: Performance issue [BUG] Performance issue Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants