New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 URLs (external links) require additional urldecoding #566

Open

1 task done

ToshY opened this issue Nov 15, 2024 · 0 comments

Open

1 task done

🐛 URLs (external links) require additional urldecoding #566

ToshY opened this issue Nov 15, 2024 · 0 comments

Labels

bug

Contributor

ToshY commented Nov 15, 2024 •

edited

Loading

Is there an existing issue for this?

I have searched the existing issues

Current Behavior

URLs, in this case "Resources" (also referred as "External links") can contain links to sites that have japanese characters in the URL path.

Example: https://api.jikan.moe/v4/anime/21/full

Results for external are the following:

Wikipedia: https://ja.wikipedia.org/wiki/ONE_PIECE_%28%E3%82%A2%E3%83%8B%E3%83%A1%29
Baidu Baike: https://baike.baidu.com/item/%E8%88%AA%E6%B5%B7%E7%8E%8B/6616881

Expected Behavior

Wikipedia: https://ja.wikipedia.org/wiki/ONE_PIECE_(アニメ)
Baidu Baike: https://baike.baidu.com/item/航海王/6616881

Steps To Reproduce

https://api.jikan.moe/v4/anime/21/full

Environment

jikan-me/jikan: 5.0.0-dev

Anything else?

Workaround

Manually urldecode the URLs that jikan returns.

The text was updated successfully, but these errors were encountered:

ToshY added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment