Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor getSeasonItems function in QuerySpecificAnimeSeasonHandler #449

Open
pushrbx opened this issue Oct 25, 2023 · 0 comments
Open

Refactor getSeasonItems function in QuerySpecificAnimeSeasonHandler #449

pushrbx opened this issue Oct 25, 2023 · 0 comments
Assignees
@pushrbx
Labels
enhancement

Comments

@pushrbx
Copy link
Collaborator

pushrbx commented Oct 25, 2023

The getSeasonRange should be inside the DefaultAnimeRepository class, and the signature of the getAiredBetween should be getAiredBetween($year, $season, $type) or we should create a getBySeason($year, $season, $type) function.

Originally posted by @pushrbx in #448 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pushrbx pushrbx

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pushrbx