Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent black and black aren't the same color #32

Open
lucasmerlin opened this issue Nov 1, 2024 · 3 comments
Open

Transparent black and black aren't the same color #32

lucasmerlin opened this issue Nov 1, 2024 · 3 comments

Comments

@lucasmerlin
Copy link
Contributor

I noticed that if parts of an image change from black (#000000FF) to transparent black (#00000000) dify doesn't notice any difference.
I believe pixelmatch has a smiliar issue: mapbox/pixelmatch#26

Someone recently opened a PR to fix this problem: mapbox/pixelmatch#142
Could we implement the same fix in dify?

@jihchi
Copy link
Owner

jihchi commented Nov 3, 2024

Hi @lucasmerlin. Thank you for the reference links.

Do you by any change have an example on hand that you can share with me so that I can reproduce and verify the issue?

@lucasmerlin
Copy link
Contributor Author

Hi, sorry I should have provided the images from the start.
Dify considers these two identical:

a


b

@jihchi
Copy link
Owner

jihchi commented Nov 3, 2024

Thank you @lucasmerlin ! I can reproduce the issue using the provided files. Let me investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants