Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: the native image should be tested in github actions #9873

Open
murdos opened this issue May 22, 2024 · 2 comments
Open

Chore: the native image should be tested in github actions #9873

murdos opened this issue May 22, 2024 · 2 comments

Comments

@murdos
Copy link
Contributor

murdos commented May 22, 2024

In the past I added the startup of the native image in b936139 but as demonstrated by #9861 this is not enough

I think we need one or two E2E tests (one for maven, and one for gradle) that generates an application, and check that there's no 500 errors.
Theses E2E could then be ran in the build_native_docker_image github action, in order to test the native image.

An alternative could be to reuse ci-tests/generate.sh in build_native_docker_image

@renanfranca
Copy link
Contributor

An alternative could be to reuse ci-tests/generate.sh in build_native_docker_image

Do you know if the following issue is related?

@atomfrede
Copy link
Member

No I would say. The linked issue is about using the existing unit and integration tests with native profile. There has been an issue with mockito if i remember correctly.
This issue should start the native image and add some modules. Maybe we can use our testsuite to do that but doing the minimal thing in ci might be enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants