Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated colors #4763

Open
DamnClin opened this issue Dec 17, 2022 · 7 comments
Open

Replace deprecated colors #4763

DamnClin opened this issue Dec 17, 2022 · 7 comments

Comments

@DamnClin
Copy link
Collaborator

DamnClin commented Dec 17, 2022

Replace the use of deprecated color tokens in src/main/style/token/_colors.scss

@pascalgrimaud pascalgrimaud changed the title Replace depecrated colors Replace deprecated colors Dec 22, 2022
@parthg2211
Copy link

Hello DamnClin , I was looking into this issue, I am new to open source, can you tell me where I can find the appropriate new color token that should be used to replace $jhlite-color-neutral-900. Any style guide that I can refer.

@DamnClin
Copy link
Collaborator Author

I think this is a question for @Gnuk or @ascelineboullen

@parthg2211
Copy link

Hello. , @Gnuk @ascelineboullen , I found this style guide https://www.figma.com/file/h2uxNtJbfPATVUMjCZJNdU/%F0%9F%91%A8%F0%9F%8F%BB%E2%80%8D%F0%9F%A6%B0-JHipster-Lite?type=design&node-id=10-87&t=Eg2bD46m03THqtO2-0.

Here I can see that for the color #0F172A the name is Gray/900. Here the color token is 900 and in the code also we can see in the variable $jhlite-color-neutral-900 the color token is 900. Can you please let me know I am searcing correctly in the style guide or am I doing something wrong

@jayasekharreddy-telluri
Copy link
Contributor

can i take these issue? @DamnClin

@DamnClin
Copy link
Collaborator Author

We still don't really know the expected outcome here

@jayasekharreddy-telluri
Copy link
Contributor

ok can you suggest some other begginer friendly issue?

@DamnClin
Copy link
Collaborator Author

ok can you suggest some other begginer friendly issue?

Hello, sorry for the late reply, I just created some good first issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@pascalgrimaud @parthg2211 @DamnClin @jayasekharreddy-telluri and others