Formative feedback #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhill1
commented
Apr 29, 2025
| output_string = output_string + str(counter) + ". " + task | ||
| counter = counter + 1 | ||
| #Code from Gemini | ||
| my_string = '1. Item 1\n2. Item 2\n3. Item 3\n4. Item 4\n5. Item 5\n' |
Owner
Author
There was a problem hiding this comment.
almost; you have output_string correct, so this line should be removed and the line below is output_string[:-1], or better yet output_string.rstrip()
jhill1
commented
Apr 29, 2025
| Input - a task to add to the list | ||
| Return - nothing | ||
| """ | ||
| with open(TASK_FILE, "a", encoding="utf-8") as file: |
jhill1
commented
Apr 29, 2025
|
|
||
| #Adding a new task to the end of the to-do list | ||
|
|
||
|
|
Owner
Author
There was a problem hiding this comment.
Try not to add additional whitespace in a function which is not the subject of the commit. Keep commits clean and use git diff to see what will change in each file.
jhill1
commented
Apr 29, 2025
| tasks = file.readlines() | ||
| """Function: remove_task | ||
| Input - a task to add to the list |
Owner
Author
There was a problem hiding this comment.
Super! Some errors in the syntax here, with a random else. The if accompanying this has gone awol...
jhill1
commented
Apr 29, 2025
| print(tasks) | ||
| elif args.remove: | ||
| remove_task(int(args.remove)) | ||
| try: remove_task(int(args.remove)) |
Owner
Author
|
@kwl520 Nice work! Despite our conversation yesterday I think you get more than you think! Sure, there are somethings that aren't working, but you're not far off a finished product here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
good effort! Almost there on all of this, with some minor errors which would not take long to fix. There are a few test failures, which you're probably aware of.
What you did well:
To improve: