Merge pull request #548 from jhedstrom/518-deprecate-subcontexts

Deprecate subcontexts in Drupal Behat Extension 4.0.0.

Author: jhedstrom

CHANGELOG.md

@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
   * [#528](https://github.com/jhedstrom/drupalextension/pull/528) Show a more helpful failure when running `@javascript`
     scenarios with incorrect configuration.
   * [#545](https://github.com/jhedstrom/drupalextension/issue/545) Remove Zombie JS testing on Travis.  
+  * [#518](https://github.com/jhedstrom/drupalextension/issue/518) Subcontexts are deprecated and will be removed in v4.1.0.
 ### Added
   * [#527](https://github.com/jhedstrom/drupalextension/pull/527) Provide a step to check that a button is not in a region.
   * [#543](https://github.com/jhedstrom/drupalextension/issue/543) Run gherkin-lint against feature files on Travis.

src/Drupal/DrupalExtension/Context/Environment/Reader/Reader.php

@@ -13,6 +13,7 @@
 use Drupal\DrupalDriverManager;
 use Drupal\Driver\SubDriverFinderInterface;
 
+use Drupal\DrupalExtension\Context\DrupalSubContextInterface;
 use RecursiveDirectoryIterator;
 use RecursiveIteratorIterator;
 use RegexIterator;
@@ -159,6 +160,12 @@ private function findSubContextClasses()
 
             // Additional subcontext locations may be specified manually in behat.yml.
             if (isset($this->parameters['subcontexts']['paths'])) {
+                if (!empty($this->parameters['subcontexts']['paths'])) {
+                    @trigger_error(
+                        'The `subcontexts.paths` parameter is deprecated in Drupal Behat Extension 4.0.0 and will be removed in 4.1.0. Normal Behat contexts should be used instead and loaded via behat.yml.',
+                        E_USER_DEPRECATED
+                    );
+                }
                 $paths = array_merge($paths, $this->parameters['subcontexts']['paths']);
             }
 
@@ -173,7 +180,8 @@ private function findSubContextClasses()
             $classes = get_declared_classes();
             foreach ($classes as $class) {
                 $reflect = new \ReflectionClass($class);
-                if (!$reflect->isAbstract() && $reflect->implementsInterface('Drupal\DrupalExtension\Context\DrupalSubContextInterface')) {
+                if (!$reflect->isAbstract() && $reflect->implementsInterface(DrupalSubContextInterface::class)) {
+                    @trigger_error('Sub-contexts are deprecated in Drupal Behat Extension 4.0.0 and will be removed in 4.1.0. Class ' . $class . ' is a subcontext. This logic should be moved to a normal Behat context and loaded via behat.yml.', E_USER_DEPRECATED);
                     $class_names[] = $class;
                 }
             }