Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail2ban role corrupts configuration.yaml if reverse proxy container is not running #48

Open
jhampson-dbre opened this issue Aug 3, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@jhampson-dbre
Copy link
Owner

If the reverse proxy container is not running (e.g. after restarting home assistant), the container info will be found, but it will not have an IP address assigned yet and set a blank list entry for trusted_proxies: in configuration.yaml. Ideally, if the reverse proxy addon is not running, we would wait for some time for it to start (or maybe try to start it?), and then either fail the task or bypass modifying the configuration.yaml (although that could leave it in a state with incorrect/no trusted_proxies defined).

Either way, fail2ban role should handle this scenario more gracefully than it does currently.

@jhampson-dbre jhampson-dbre added the enhancement New feature or request label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant