Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark an elephpant as "not interested in" for trades #25

Open
asgrim opened this issue Jan 13, 2020 · 4 comments
Open

Mark an elephpant as "not interested in" for trades #25

asgrim opened this issue Jan 13, 2020 · 4 comments
Labels
improvement adjustment or improvement of functionalities

Comments

@asgrim
Copy link

asgrim commented Jan 13, 2020

I'd like to be able to mark an elePHPant as one that I am not interested in, so that people don't ask me for trades.

My scenario is that I'm waiting for a few elePHPants to reach me that I don't actually have yet. Lets say I'm waiting for a hypothetical maroon elePHPant. The issue is I get trade notifications like "Can I swap my maroon elePHPant for one of your Roave elephpants"? To avoid this, I should be able to mark the maroon elePHPant in some way so it doesn't show in trades that I want to acquire this maroon elePHPant.

My current workaround is that I just mark all the ones I will eventually acquire as already having, but then this skews the table, makes it look like I possess more elePHPants than I really do.

@jgrossi
Copy link
Owner

jgrossi commented Jan 13, 2020

good one! thanks for sharing man 👏

@jgrossi jgrossi added the improvement adjustment or improvement of functionalities label Jan 13, 2020
@IgorDuarte17
Copy link
Collaborator

we have to discuss a way to implement this solution

@pgrimaud
Copy link
Contributor

pgrimaud commented Jul 4, 2020

Hey, I'm interested in discussing this feature, then develop it.

And I think we could also add the option to set how many elePHPants your want to trade, per species.

e.g. : I have 2 Original Blue - First Blue elePHPants. So I will appear in trade area with 1 Original Blue - First Blue to trade. But I would like to keep this 2 buddies because one is the Nexen model and the other the Alter Way.

@Wilkins
Copy link
Contributor

Wilkins commented Apr 12, 2021

Hi,
what about setting a "keeping limit" per elephpant ?
Today that limit is 1 for everyone, for every elephpant type.
If this was changeable on My Herd page, then I could set my herd :

  • Enfys : I have 2, I'm keeping 1 (1 is tradable)
  • HaPHPy : I have 1, I'm keeping 0 (the only one I have is tradable)
  • Las Vegas : I have 0, I'm keeping 0 (I don't want any to trade)
  • ConFoo : I have 6, I'm keeping 6 (because I want to keep them all)
  • GrandPa : I have 1, I'm keeping 4 (because I want to have more, up to 4)

We could add a column named "keeping" in elephpant_user table, with 1 as default

I have to say that proposal handles several problems, but this seems only useful for large collections and a little too complicated for the majority of users...
So I guess that should be hidden by default, and visible with additional clicks.

What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement adjustment or improvement of functionalities
Projects
None yet
Development

No branches or pull requests

5 participants