fix(oidc): add GitHub actions issuer customization for enterprise
#163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks that the issuer properly starts with https://token.actions.githubusercontent.com instead of a strict equality. Enterprise administrators can customize their OIDC issuer to append the enterprise slug at the end, e.g.: https://token.actions.githubusercontent.com/jfrog For more information see: https://docs.github.com/en/enterprise-cloud@latest/actions/security-for-github-actions/security-hardening-your-deployments/about-security-hardening-with-openid-connect\#customizing-the-issuer-value-for-an-enterprise
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
acouvreur
had a problem deploying
to
development
GitHub Actions
Failure
acouvreur
had a problem deploying
to
development
GitHub Actions
Error
alexhung
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that the issuer properly starts with https://token.actions.githubusercontent.com instead of a strict equality.
Enterprise administrators can customize their OIDC issuer to append the enterprise slug at the end, e.g.: https://token.actions.githubusercontent.com/jfrog
For more information see: https://docs.github.com/en/enterprise-cloud@latest/actions/security-for-github-actions/security-hardening-your-deployments/about-security-hardening-with-openid-connect\#customizing-the-issuer-value-for-an-enterprise
I could not run acceptance tests because I don't have a license