Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing MyJFrog API Token warning when not specified #132

Open
5 tasks done
mymasse opened this issue Sep 27, 2024 · 2 comments
Open
5 tasks done

Missing MyJFrog API Token warning when not specified #132

mymasse opened this issue Sep 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mymasse
Copy link

mymasse commented Sep 27, 2024

Describe the bug
When not specifying the deprecated myjfrog_api_token in the provider configuration or using JFROG_MYJFROG_API_TOKEN environment variable a warning will be printed all the time.

Sample configuration

terraform {
  required_version = ">= 1.0"  
  required_providers {    
    platform = {
      source  = "jfrog/platform"
      version = "1.12.0"
    }
  }
}

provider "platform" {
  url          =  <VALID URL>
  access_token = <VALID ACCESS TOKEN>
}

Requirements for and issue

  • A description of the bug
  • A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue). If this is not supplied, this issue will likely be closed without any effort expended.
  • Your version of artifactory (you can curl it at $host/artifactory/api/system/version
  • Your version of terraform
  • Your version of terraform provider

Versions
Artifactory: 7.90.13
Terraform: 1.9.6
Provider: 1.12.0

Expected behavior
If this argument is deprecated why even print a warning if not used.

Additional context
N/A

@mymasse mymasse added the bug Something isn't working label Sep 27, 2024
@alexhung
Copy link
Member

alexhung commented Sep 27, 2024

@mymasse Deprecating an attribute is a multi-steps process. The first step is to mark the attribute as 'deprecated' whilst retaining all functionality. The next step is to remove functionality with next major release and remove the attribute altogether.

So expect the warning message be gone in next major release.

See Terraform doc for reference.

@zamanh
Copy link

zamanh commented Dec 5, 2024

Why should this be seen for those who aren't using that provider causing this warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants