Gh 621 bulk import #815
Gh 621 bulk import #815
Conversation
Remove repos project key default
next steps: handle the special case of docker local repos (we need to fetch the version number which requires an extra call) test management of netrc (we don't want to mess up someones file) exclude resources found in the local terraform state
* master: Update devfile.yaml trying out spaces
…tainering this script isn't done, but it's also out-of-scope
|
@chb0github Looks like I was wrong and Docker v1 is still very much supported.
|
|
@alexhung - no, it doesn't actually try clicking v1 and hitting "submit" |
|
@chb0github No problem creating a local Docker v1 repository
|
|
|
|
So, do you want me to add the legacy code for v1, or is this good to commit and get feedback |
|
@chb0github So the Docker v1 issue seems to be a bug from Artifactory. The version you are using is 7.56.0, which is old. The local version I am running is 7.68.7 which support v1 again. Same with latest cloud version 7.69.4. So we need to have Docker v1 support in the script. |
…overed a bug in the netrc logic that needs fixing (removing for now).
…form-provider-artifactory into jfrogGH-621-bulk-import * 'jfrogGH-621-bulk-import' of github.com:chb0github/terraform-provider-artifactory: fix store_artifacts_locally docs to reflect reality JFrog Pipelines - Add Artifactory version to CHANGELOG.md Update CHANGELOG Update module path from 'v8' to 'v9' Add planmodifier.RequiresReplace() to "key" attribute Update CHANGELOG Migrate 'artifactory_backup' resource to terraform-plugin-framework Update CHANGELOG Update validation for "project_environments" to allow empty list Update documentation JFrog Pipelines - Add Artifactory version to CHANGELOG.md Update CHANGELOG Add "force_conan_authentication" attribute to local, virtual, and federated repo resources and data sources
|
docker v1 support is added, and the script is updated |
|
I'm not particularly happy with the internal code formatting due to the need to output also with format to the import file, but using JQ was 6x faster than using the shell. I was shocked. |
|
If there is some input in the future, please tag me |
|
@danielmkn waiting on you, buddy |
|
@chb0github, can you please add some documentation on that? |
|
Where would you like me to put it? It was marked as no change log Please confer with Alex. Also, the app is self documenting, per best practices |
|
@danielmkn - where would you like this documentation? And, did you consult with @alexhung ? |
|
Hey Guys, if we're not going to merge it in, then an explanation why would be great. |
|
Note We will put this PR on hold for the immediate future. Factors that contribute to this decision include:
In the meantime, this PR will remain open and available for others to copy and use in their own trials and experiments. We welcome any suggestions or feedback so when we are ready to work on this in the future, we will have a better idea on what our customers want. |
|
Ok, So, having thought about this more, a more terraform idiosyncratic approach to this would be to :
Although, right now the data source for repositories is still pending merge, and there aren't data sources for the other resources. |
Ok, this is working, but I am working on an improvement.
You see, if I fetch all the repo data, regardless of type, then I just remap it all. But, it turns out only
docker localis our problem child, and thedockerApiVersionis the only thing I can't know with a single API call. I'll post the new code that carves these out as an exception for "performance" reasons - only those repos will get the double fetch which, definitely will result in a lot less calls, but for a lot more code (see below).to use this tool, you run:
Duplicate resource requests are discarded