No error if trying to add a user that does not exist to artifactory_group users_names list

[hannahlindblad]

Describe the bug

If I try to add a user that does not exist, the provider silently fails to do so but the apply is successful. I.e. for the terraform code

resource "artifactory_group" "test" {
  name             = "test-group"
  description      = "test"
  admin_privileges = false
  users_names = ["[email protected]"]
}

The apply is successful but there is no user added to the group.

Provider version: 12.4.1
Terraform version: v1.9.8
Artifactory version: Artifactory/7.100.2 80002900

Requirements for and issue

• A description of the bug
• A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue). If this is not supplied, this issue will likely be closed without any effort expended.
• Your version of artifactory (you can curl it at $host/artifactory/api/system/version
• Your version of terraform
• Your version of terraform provider

Expected behavior

I would expect the apply to fail since the user does not exist.

Additional context

[alexhung]

@hannahlindblad Thanks for the report. This is a limitation of the Artifactory API the provider uses for managing groups. This set of API is deprecated and our plan is to deprecate this artifactory_group resource and create a new Group resource platform_group (which will use new Access API) in the Platform provider. The Access API for groups validates the members field for user existence.

[alexhung]

Related to #1104