Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server configuration improvements #227

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Server configuration improvements #227

wants to merge 2 commits into from
+212 −16

Conversation

RobiNino
Copy link
Contributor

@RobiNino RobiNino commented Nov 19, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Note:

  • The internal setup-jfrog-cli-server server ID will no longer be available. Set a custom server ID if you need to reference the server directly.

Improvements:

@RobiNino RobiNino added the improvement Automatically generated release notes label Nov 19, 2024
@sverdlov93
Copy link
Contributor

Unique default server ID for each run of a workflow

breaking change? if someone used the old one?

@RobiNino
Copy link
Contributor Author

The pervious server ID was never documented, using it directly was as using an internal code. I can add the breaking change label if you think it necessary but I'm not sure this actually counts as one.

@sverdlov93
Copy link
Contributor

The pervious server ID was never documented, using it directly was as using an internal code. I can add the breaking change label if you think it necessary but I'm not sure this actually counts as one.

https://github.com/search?q=%22setup-jfrog-cli-server%22+language%3AYAML&type=code&l=YAML

@RobiNino RobiNino added breaking change Automatically generated release notes and removed breaking change Automatically generated release notes labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@yahavi yahavi Awaiting requested review from yahavi

@EyalDelarea EyalDelarea Awaiting requested review from EyalDelarea

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting --url option is mandatory error for ping and upload commands
2 participants
@RobiNino @sverdlov93