Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically configured JFROG_CLI_BUILD_NAME not specific enough #159

Open
mhuijgen opened this issue May 30, 2024 · 0 comments
Open

Automatically configured JFROG_CLI_BUILD_NAME not specific enough #159

mhuijgen opened this issue May 30, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@mhuijgen
Copy link

Is your feature request related to a problem? Please describe.

Hi,

We are running into the issue that the automatically configured JFROG_CLI_BUILD_NAME which is currently set to the workflow name is not specific enough.

We have a lot of repositories, all publishing to the same project in JFROG into the same build-info repository. If we examine the build-info repository all build names for all repositories are the same: "CI/CD", since all repositories have the same name for the CI/CD workflow.

Describe the solution you'd like to see

I think it would make sense to include the repository name as well besides the workflow name.

https://github.com/jfrog/setup-jfrog-cli/blob/ac320860ee08886f9762fc8eb4186f994deadecb/src/utils.ts#L344C1-L345C1
let buildNameEnv: string | undefined = process.env.GITHUB_WORKFLOW;
to

let buildNameEnv: string | undefined = process.env.GITHUB_REPOSITORY + '/' + process.env.GITHUB_WORKFLOW;
This would allow us to identify the build-info by its name, instead of having

Describe alternatives you've considered

The alternative would be to require all teams to add an extra run step to their workflows overriding the too generic JFROG_CLI_BUILD_NAME.

Additional context

No response

@mhuijgen mhuijgen added the feature request New feature or request label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant