Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lifecycle operations to sync mode as default #2754

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Lifecycle operations to sync mode as default #2754

merged 2 commits into from
Nov 12, 2024

Conversation

lesnerd
Copy link
Contributor

@lesnerd lesnerd commented Nov 12, 2024

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

sverdlov93
sverdlov93 reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be done by c.BoolT()

@lesnerd lesnerd changed the title Release-bundle creation to sync mode as default Lifecycle operations to sync mode as default Nov 12, 2024
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Nov 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 12, 2024
@sverdlov93 sverdlov93 merged commit da81635 into jfrog:dev Nov 12, 2024
59 of 63 checks passed
@sverdlov93 sverdlov93 added improvement Automatically generated release notes breaking change Automatically generated release notes and removed improvement Automatically generated release notes labels Nov 12, 2024
@BrewTestBot BrewTestBot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
breaking change Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lesnerd @sverdlov93 @davidlesfrog