Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix npm publish NPE #1307

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Fix npm publish NPE #1307

merged 3 commits into from
Nov 24, 2021
+99 −55

Conversation

RobiNino
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Following #1306

@RobiNino RobiNino added the safe to test Approve running integration tests on a pull request label Nov 24, 2021
eyalbe4
eyalbe4 requested changes Nov 24, 2021
View reviewed changes
utils/cliutils/utils.go Show resolved Hide resolved
npm_test.go Show resolved Hide resolved
pip_test.go Show resolved Hide resolved
@RobiNino RobiNino merged commit 0022cd1 into jfrog:dev Nov 24, 2021
@RobiNino RobiNino deleted the npm-npe branch November 24, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
safe to test Approve running integration tests on a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobiNino @eyalbe4