Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Artifactory] Expanding CustomVolumeMounts Parameter #1952

Closed
wants to merge 4 commits into from

Conversation

pablitoc
Copy link

@pablitoc pablitoc commented Jan 9, 2025

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md
  • confluence is not allowing me to make changes
  • Title of the PR starts with chart name (e.g. [artifactory])

What this PR does / why we need it:
This PR is related to support tickets 333456 and 313254. It adds the ability to apply custom volume mounts to Jfconnect, Access, Observability, and Event containers. WE need this because all containers should have the ability to apply extra volumes. In our use case the listed containers require our TLS certificates to communicate past our firewall.

Special notes for your reviewer:
not able to lint as the brew kubelav package is no longer available

Copy link

github-actions bot commented Jan 9, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@pablitoc pablitoc changed the title Expanding CustomVolumeMounts Parameter [Artifactory] Expanding CustomVolumeMounts Parameter Jan 9, 2025
@pablitoc
Copy link
Author

pablitoc commented Jan 9, 2025

I have read the CLA Document and I hereby sign the CLA

@pablitoc
Copy link
Author

pablitoc commented Jan 9, 2025

recheck

@chukka
Copy link
Collaborator

chukka commented Jan 10, 2025

@pablitoc Appreciate this PR ! However, This is already actioned internally few weeks back and will be part of artifactory 7.104.x minor ( End of this month) release.

@chukka chukka closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants