Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GITHUB_AUTH by AUTH_GITHUB #309

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Conversation

jfmengels
Copy link
Owner

@jfmengels jfmengels commented Nov 10, 2024

Environment variables in GitHub can't start with "GITHUB_".

I created an environment for GitHub Actions with a AUTH_GITHUB, which will be used for tests that use --template. Hopefully this will help prevent rate limits 🤞

Environment variables in GitHub can't start with "GITHUB_".
@jfmengels
Copy link
Owner Author

I don't know if it worked, I guess we'll see as we do more changes 🤷‍♂️

@jfmengels jfmengels merged commit f9a57e4 into main Nov 10, 2024
3 checks passed
@jfmengels jfmengels deleted the change-github-auth-env-variable branch November 10, 2024 23:55
@lishaduck
Copy link
Contributor

It worth considering that now it'll directly count against you (i.e., if say I wrote some code to spam the api, you'd be the one flagged for abuse), perhaps you should use secrets.GITHUB_TOKEN (built-in token, granular permissions), which would count against the triggerer.

@lishaduck lishaduck mentioned this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants