Tweak docs #291
Merged
Tweak docs #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jfmengels
reviewed
Oct 31, 2024
| @@ -6,7 +6,7 @@ Run [`elm-review`] from Node.js. | |||
|
|
|||
| ## Installation | |||
|
|
|||
| ```bash | |||
There was a problem hiding this comment.
What's the difference in practice? Asking because I always do bash.
There was a problem hiding this comment.
Purely semantic, as far as I can tell. I wrote this two months ago, so 🤷♂️
I don't think it makes a difference to syntax highlighting (on gh at least), etc, but I use zsh, Simon uses fish, etc.
I just always use sh for shell stuff unless I need a specific shell.
jfmengels
reviewed
Oct 31, 2024
Update lib/options.js Co-authored-by: Jeroen Engels <[email protected]>
|
Oh, tests are failing b/c of new elm-syntax. I'll send in another PR 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #253.
Conflicts with #290, please merge that first.