Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump stil4m/elm-syntax from 7.2.9 to 7.3.6 in /review #251

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps stil4m/elm-syntax from 7.2.9 to 7.3.6.

Changelog

Sourced from stil4m/elm-syntax's changelog.

[7.3.6] - 2024-09-11

  • The parser is stricter in a few cases where code that was incorrect (according to the Elm compiler) was successfully parsed: tuple patterns and tuple type annotations with more than 3 parts, non-associative operators (so no more a < b < c), lambda indentation
  • The parser removes incorrect failures with specific operator combinations like a + b /= 0 due to specifics of the pratt parser
  • Parsing is about 50% faster than the previous release!

[7.3.5] - 2024-08-30

  • The parser is stricter in a few cases where code that was incorrect (according to the Elm compiler) was successfully parsed: tuple expressions with more than 3 parts, and record access on most things
  • Parsing is about 6 times faster than the previous release!

[7.3.4] - 2024-07-26

Parsing is faster by ~90%. A big thank you to @​lue-bird for finding and introducing a huge amount of performance improvements.

[7.3.3] - 2024-07-18

Parser rewrite using a Pratt parser

This patch is a major rewrite of the parser, which now uses a Pratt parser under the hood (see https://martin.janiczek.cz/2023/07/03/demystifying-pratt-parsers.html for an explanation).

Prior to this version, the source code was parsed and then post-processed - to rebalance the tree around operator precedence and to attach documentation comments. This is now all done in a single pass, which improves performance by about 15%.

This rewrite includes a few additional changes:

  • a few bug fixes where code that was incorrect Elm code (according to the Elm compiler) was successfully parsed
  • better performance, parsing should now be faster
  • support for multiline strings in patterns

A big thank you to @​jiegillet and @​janiczek for their help.

Deprecation of Elm.Writer

The Elm.Writer module has never been very good and tended to, and we do not desire maintaining it, and it will therefore likely be removed in a future major version. We highly recommend using the-sett/elm-syntax-dsl instead, which is much better anyways.

[7.3.2] - 2022-09-03

  • Stop parsing FloatPattern (this is an invalid pattern in Elm 0.19)
  • Stop parsing Destructuring declaration (this is an invalid declaration in Elm 0.19)
  • Fail to parse when doing exposing clause is empty (exposing ())
  • Fail to parse when encountering an annotation for the wrong declaration (a : T followed by b = 1)
  • Various performance improvements that make the parser 6% to 9% faster

[7.3.1] - 2022-08-16

  • Fixed an infinite recursion during parsing of a file.

[7.3.0] - 2023-08-16

... (truncated)

Commits
  • 1e1ae7e 7.3.6
  • 1093a42 correct float handling of the custom parser
  • 09c9b69 clarify what is meant with tuples
  • 7a1be94 avoid a new allocation
  • 924e9b6 move infixOperatorAndThen into extendedSubExpressionOptimisticLayout
  • 27931e1 mention fixed incorrect failures on specific operator combinations in changelog
  • d604554 apply tests for #258 by @​jfmengels
  • 8c5a9d6 _ for unused pattern variable
  • 5705bc3 remove unused oneOfNs
  • 33fe359 correct and speed up infix operator handling
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [stil4m/elm-syntax](https://github.com/stil4m/elm-syntax) from 7.2.9 to 7.3.6.
- [Changelog](https://github.com/stil4m/elm-syntax/blob/master/CHANGELOG.md)
- [Commits](stil4m/elm-syntax@7.2.9...7.3.6)

---
updated-dependencies:
- dependency-name: stil4m/elm-syntax
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file elm Pull requests that update Elm code labels Sep 16, 2024
@lishaduck
Copy link
Contributor

Should be good to merge (SemVer minor), but we probably ought to wait until CI's fixed (#176 (comment)).

Originally posted by @lishaduck in #242 (comment)

@jfmengels
Copy link
Owner

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 28, 2024

Looks like stil4m/elm-syntax is up-to-date now, so this is no longer needed.

@dependabot dependabot bot closed this Oct 28, 2024
@dependabot dependabot bot deleted the dependabot/elm/review/stil4m/elm-syntax-7.3.6 branch October 28, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file elm Pull requests that update Elm code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants