Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow relative AND absolute paths when ignoring directories #150

Merged
merged 5 commits into from
May 2, 2024
Merged

Allow relative AND absolute paths when ignoring directories #150

merged 5 commits into from
May 2, 2024

Conversation

jamesrweb
Copy link
Contributor

Fixes #149.

Convert absolute paths to be relative to the project being reviewed.

@jfmengels jfmengels merged commit 28869fc into jfmengels:main May 2, 2024
2 of 3 checks passed
@jfmengels
Copy link
Owner

Thank you @jamesrweb 😊

I had to reverse the arguments to path.relative, but apart from that it seems to work well ☺️

@jamesrweb
Copy link
Contributor Author

Thank you @jamesrweb 😊

I had to reverse the arguments to path.relative, but apart from that it seems to work well ☺️

Nice! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow relative AND absolute paths when ignoring directories
2 participants
@jamesrweb @jfmengels