Don't disable colors when doing NO_COLOR=""

jfmengels · jfmengels · commit b1a70f8ae06f · 2023-10-26T21:31:07.000+02:00
diff --git a/lib/main.js b/lib/main.js
@@ -1,11 +1,11 @@
 process.title = 'elm-review';
 
 if (!process.argv.includes('--no-color')) {
-  if (process.env['NO_COLOR'] === undefined) {
+  if (process.env.NO_COLOR !== undefined && process.env.NO_COLOR !== '') {
+    process.argv.push('--no-color');
+  } else {
     // Force `chalk` to add colors by default.
     process.argv.push('--color');
-  } else {
-    process.argv.push('--no-color');
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,11 @@`
`1`	`1`	`process.title = 'elm-review';`
`2`	`2`
`3`	`3`	`if (!process.argv.includes('--no-color')) {`
`4`		`- if (process.env['NO_COLOR'] === undefined) {`
	`4`	`+ if (process.env.NO_COLOR !== undefined && process.env.NO_COLOR !== '') {`
	`5`	`+ process.argv.push('--no-color');`
	`6`	`+ } else {`
`5`	`7`	// Force `chalk` to add colors by default.
`6`	`8`	`process.argv.push('--color');`
`7`		`- } else {`
`8`		`- process.argv.push('--no-color');`
`9`	`9`	`}`
`10`	`10`	`}`
`11`	`11`