Additionally resolve --elm-format-path from PATH

Author: jfmengels

CHANGELOG.md

@@ -4,6 +4,7 @@
 
 - Publicly document the `--fix-all-without-prompt` CLI flag. Please use it well!
 - The `--compiler` flag now additionally resolves the compiler path using the `PATH` environment variable (more easily enabling `elm-review --compiler lamdera` for instance).
+- The `--elm-format-path` flag now additionally resolves the path to `elm-format` using the `PATH` environment variable.
 - Fixed an issue where the initial rule created with `elm-review new-package` was always a module rule, even when it was requested to be a project rule. Thanks to [@mateusfpleite](https://github.com/mateusfpleite)!
 - Plenty of behind the scenes improvement to the maintenance of the repository. Thanks to [@lishaduck](https://github.com/lishaduck) for all of those.
 

lib/autofix.js

@@ -188,9 +188,10 @@ function formatFileContent(options, file, filePath) {
     ['--elm-version=0.19', '--stdin', '--output', filePath],
     {
       input: file.source,
-      env: hasElmFormatPathFlag
-        ? process.env
-        : {...process.env, [pathKey]: backwardsCompatiblePath()}
+      env: {
+        ...process.env,
+        [pathKey]: backwardsCompatiblePath(options.elmFormatPath)
+      }
     }
   );
 

lib/elm-binary.js

@@ -17,13 +17,9 @@ const {backwardsCompatiblePath} = require('./npx');
  * @returns {Promise<Path>}
  */
 async function getElmBinary(options) {
-  let pathFolders = backwardsCompatiblePath();
-  if (options.compiler) {
-    pathFolders = pathFolders + path.delimiter + options.userSrc();
-  }
   try {
     const elmBinaryPath = await which(options.compiler ?? 'elm', {
-      path: pathFolders
+      path: backwardsCompatiblePath(options.compiler)
     });
     return path.resolve(elmBinaryPath);
   } catch {

lib/npx.js

@@ -61,9 +61,10 @@ const pathKey = getPathKey();
  *
  * This can be removed in a major version.
  *
+ * @param {Path | undefined} providedBinaryPath
  * @returns {Path}
  */
-function backwardsCompatiblePath() {
+function backwardsCompatiblePath(providedBinaryPath) {
   return [
     ...process
       .cwd()
@@ -72,6 +73,11 @@ function backwardsCompatiblePath() {
         [...parts.slice(0, index + 1), 'node_modules', '.bin'].join(path.sep)
       )
       .reverse(),
+    [
+      ...(providedBinaryPath
+        ? [path.resolve(path.dirname(providedBinaryPath))]
+        : [])
+    ],
     process.env[pathKey]
   ].join(path.delimiter);
 }