Upgrade test dependencies when running init or new-package

Author: jfmengels

lib/remote-template.js

@@ -98,9 +98,6 @@ async function getRemoteElmJson(
       MinVersion.updateToAtLeastMinimalVersion(packageVersion);
   }
 
-  elmJson['test-dependencies'].direct = {};
-  elmJson['test-dependencies'].indirect = {};
-
   return TemplateDependencies.update(options, elmJson);
 }
 

lib/template-dependencies.js

@@ -273,15 +273,44 @@ async function update(options, elmJson) {
   delete elmJson.dependencies.direct['jfmengels/elm-review'];
   delete elmJson.dependencies.direct['stil4m/elm-syntax'];
 
-  // TODO Upgrade test dependencies too for init or new-package
+  const stringifiedElmJson = JSON.stringify({
+    ...elmJson,
+    dependencies: {direct: {}, indirect: {}},
+    'test-dependencies': {direct: {}, indirect: {}}
+  });
+
   elmJson.dependencies = solve(
     options,
     elmJson['elm-version'],
-    JSON.stringify({...elmJson, dependencies: {direct: {}, indirect: {}}}),
+    stringifiedElmJson,
     extra,
     true
   );
 
+  const testDependenciesEntries = Object.entries(
+    elmJson['test-dependencies'].direct
+  );
+  if (testDependenciesEntries.length !== 0) {
+    /** @type {Record<string, string>} */
+    const packagesToAdd = {};
+    testDependenciesEntries.forEach(([pkg, version]) => {
+      packagesToAdd[pkg] = `${version} <= v < ${nextMajorVersion(version)}`;
+    });
+
+    const testDependencies = solve(
+      options,
+      elmJson['elm-version'],
+      stringifiedElmJson,
+      packagesToAdd,
+      true
+    );
+
+    elmJson['test-dependencies'] = filterOutDuplicateDependencies(
+      testDependencies,
+      elmJson.dependencies
+    );
+  }
+
   teardownDependenciesProvider();
 
   return elmJson;

test/run-snapshots/elm-review-something-for-new-rule/review/elm.json

@@ -36,7 +36,9 @@
         }
     },
     "test-dependencies": {
-        "direct": {},
+        "direct": {
+            "elm-explorations/test": "2.1.2"
+        },
         "indirect": {}
     }
 }

test/run-snapshots/elm-review-something/review/elm.json

@@ -36,7 +36,9 @@
         }
     },
     "test-dependencies": {
-        "direct": {},
+        "direct": {
+            "elm-explorations/test": "2.1.2"
+        },
         "indirect": {}
     }
 }