Skip to content

Commit 3613e7a

Browse files
committed
Change the app hash for remote templates to include the path
This prevents a crash when using two different template configuration at different folder paths (/preview1 and /preview2) and re-using the result cache. The crash happens because we would be using the result tied to the built application of a different compilation, meaning some fields would be mismatched and result in "field is undefined"-like errors. We solve this by hvaing both the path to the folder and the commit to the path of the result cache, removing the confusion.
1 parent 614556e commit 3613e7a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/build.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ async function buildFromGitHubTemplate(options, template) {
284284
}
285285

286286
return {
287-
appHash: commit,
287+
appHash: `${template.pathToFolder}/${commit}`,
288288
elmModulePath,
289289
reviewElmJsonPath: null,
290290
reviewElmJson

0 commit comments

Comments
 (0)