Skip to content

Commit 0bceae3

Browse files
committed
fix: more types
This seems to be the way you're supposed to write overloads, but it does feel wrong.
1 parent b9f2686 commit 0bceae3

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

lib/app-wrapper.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,7 @@ function subscribe(port) {
109109
function unsubscribe(port) {
110110
// eslint-disable-next-line promise/prefer-await-to-callbacks -- Callbacks are still needed here.
111111
return (callback) => {
112-
listeners[port] = listeners[port].filter(
113-
(/** @type {Listened<unknown>} */ fn) => fn === callback
114-
);
112+
listeners[port] = listeners[port].filter((fn) => fn === callback);
115113
};
116114
}
117115

lib/parse-elm.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,12 @@ function terminateWorkers() {
6363
async function parse(elmParserPath, source) {
6464
return await new Promise((resolve, reject) => {
6565
const availableWorker = findInactiveWorker();
66+
6667
/** @type {ParseJob} */
6768
const queueItem = {
6869
source,
6970
elmParserPath,
71+
7072
callback: (/** @type {Error | undefined} */ error, result) => {
7173
if (error === undefined) {
7274
resolve(result);

lib/types/parse-elm.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,11 @@ import type {SendPort, SubscribePort} from './promisify-port.js';
55
export type ParseJob = {
66
elmParserPath: Path;
77
source: Source;
8-
callback: Callback;
9-
};
108

11-
type Callback = {
12-
(error: Error): void;
13-
(error: undefined, result: Ast): void;
9+
callback: {
10+
(error: Error): void;
11+
(error: undefined, result: Ast): void;
12+
};
1413
};
1514

1615
export type ParserApp = {

0 commit comments

Comments
 (0)