Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This is only for mac? #8

Open
alesanchezr opened this issue Sep 9, 2019 · 1 comment
Open

This is only for mac? #8

alesanchezr opened this issue Sep 9, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@alesanchezr
Copy link
Collaborator

Maybe check the mac version and don't run the scrip if its not compatible?

flask-microservices-boilerplate/install.sh

Line 7 in 297a623

trap 'last_command=$current_command; current_command=$BASH_COMMAND' DEBUG

@jferragut
Copy link
Owner

To expand on this. Yes, the current install.sh script is designed for mac as it leverages homebrew to install some dependencies.

Maybe check if mac || linux and use the correct command depending on OS. Either that or we can split off and make different installers (ie. install-mac.sh, install-linux.sh, etc)

@jferragut jferragut added enhancement New feature or request help wanted Extra attention is needed labels Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alesanchezr @jferragut