Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Command.run(String[]) #4

Open
jfcameron opened this issue Dec 19, 2018 · 0 comments
Open

Refactor Command.run(String[]) #4

jfcameron opened this issue Dec 19, 2018 · 0 comments

Comments

@jfcameron
Copy link
Owner

jfcameron commented Dec 19, 2018

This function default constructs a Parameter.List then configures it by parsing the program's arg list. Since Parameter.List is an abstraction of a program's arg list (partial or full) the work of creating a Parameter.List from a String[] should be done in a ctor, it should not be done externally. additionally, not sure why Parameter.List can be default constructed (what is the meaning of a default constructed Parameter.List? What does such a thing represent?). The work done in this function should be moved to a ctor of Parameter.List:
Parameter.List(String[])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant