From 294159d62114ea2f130f567865afd0259462017c Mon Sep 17 00:00:00 2001 From: saurabhjdas786 Date: Fri, 25 Mar 2022 12:25:09 -0300 Subject: [PATCH] refactor(CrudOrderA, CrudOrderB): pull up var and method - The price variable in the sub class is common for all the orders. - Also the class CrudOrderB doesn't actually override any methods as such. - Hence pulled the price variable along with the getter and setter of the same. --- src/test/java/org/jfaster/mango/crud/CrudOrderA.java | 10 ++++++++++ src/test/java/org/jfaster/mango/crud/CrudOrderB.java | 10 ---------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/test/java/org/jfaster/mango/crud/CrudOrderA.java b/src/test/java/org/jfaster/mango/crud/CrudOrderA.java index d8016db8..90e92dbe 100644 --- a/src/test/java/org/jfaster/mango/crud/CrudOrderA.java +++ b/src/test/java/org/jfaster/mango/crud/CrudOrderA.java @@ -24,6 +24,8 @@ */ public class CrudOrderA { + protected int price; + @ID() private String id; @@ -45,6 +47,14 @@ public int getUserId() { public void setUserId(int userId) { this.userId = userId; } + + public int getPrice() { + return price; + } + + public void setPrice(int price) { + this.price = price; + } } diff --git a/src/test/java/org/jfaster/mango/crud/CrudOrderB.java b/src/test/java/org/jfaster/mango/crud/CrudOrderB.java index 441e2d5b..b30358ff 100644 --- a/src/test/java/org/jfaster/mango/crud/CrudOrderB.java +++ b/src/test/java/org/jfaster/mango/crud/CrudOrderB.java @@ -26,19 +26,9 @@ */ public class CrudOrderB extends CrudOrderA { - private int price; - @Ignore private String stat; - public int getPrice() { - return price; - } - - public void setPrice(int price) { - this.price = price; - } - public String getStat() { return stat; }