From bacbfe589eee06b72fead4344ea7f6a229e8accf Mon Sep 17 00:00:00 2001 From: David Collom Date: Wed, 12 Jul 2023 15:20:22 +0100 Subject: [PATCH] Revert "helm chart fixes (#102)" (#103) This reverts commit 918522430c492c7fd26307f00c9f1326f7a5aa6b. --- deploy/charts/version-checker/Chart.yaml | 4 ++-- pkg/metrics/metrics.go | 13 ------------- 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/deploy/charts/version-checker/Chart.yaml b/deploy/charts/version-checker/Chart.yaml index 52d7b21..a0b3655 100644 --- a/deploy/charts/version-checker/Chart.yaml +++ b/deploy/charts/version-checker/Chart.yaml @@ -1,8 +1,8 @@ apiVersion: v1 appVersion: "v0.2.2" -version: v0.2.3 +version: 0.2.3 description: A Helm chart for version-checker -home: https://github.com/jetstack/version-checker +home: https://github.com/jetstack/verison-checker name: version-checker maintainers: - name: davidcollom diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go index ddd067a..be93362 100644 --- a/pkg/metrics/metrics.go +++ b/pkg/metrics/metrics.go @@ -22,7 +22,6 @@ type Metrics struct { registry *prometheus.Registry containerImageVersion *prometheus.GaugeVec - containerImageErrors *prometheus.CounterVec log *logrus.Entry // container cache stores a cache of a container's current image, version, @@ -48,26 +47,14 @@ func New(log *logrus.Entry) *Metrics { "namespace", "pod", "container", "image", "current_version", "latest_version", }, ) - containerImageErrors := prometheus.NewCounterVec( - prometheus.CounterOpts{ - Namespace: "version_checker", - Name: "image_failures", - Help: "Where the version-checker was unable to get the latest upstream registry version", - }, - []string{ - "namespace", "pod", "container", "image", - }, - ) registry := prometheus.NewRegistry() registry.MustRegister(containerImageVersion) - registry.MustRegister(containerImageErrors) return &Metrics{ log: log.WithField("module", "metrics"), registry: registry, containerImageVersion: containerImageVersion, - containerImageErrors: containerImageErrors, containerCache: make(map[string]cacheItem), } }