Skip to content

Commit dfca944

Browse files
authored
boxcli: increase shell test timeout to 3 mins (#152)
This is a workaround for some test runs that are failing due to how long it takes to install Nix packages. We need to figure out how to cache these instead.
1 parent f829901 commit dfca944

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

.github/workflows/tests.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,10 @@ jobs:
5050
- name: Run tests
5151
run: |
5252
. /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh
53-
go test -v ./...
53+
go test ./...
5454
5555
test-darwin:
56+
if: ${{ false }} # disable until we figure out Homebrew rate limiting
5657
runs-on: macos-12
5758
steps:
5859
- uses: actions/checkout@v3
@@ -69,6 +70,7 @@ jobs:
6970
HOMEBREW_NO_EMOJI: 1
7071
HOMEBREW_NO_ENV_HINTS: 1
7172
HOMEBREW_NO_INSTALL_CLEANUP: 1
73+
HOMEBREW_GITHUB_API_TOKEN: ${{ github.token }}
7274
run: |
7375
brew update
7476
brew install dash zsh
@@ -77,4 +79,4 @@ jobs:
7779
- name: Run tests
7880
run: |
7981
. /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh
80-
go test -v ./...
82+
go test ./...

boxcli/shell_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@ const (
5151
// waiting for a shell prompt.
5252
shellMaxStartupReads = 10_000
5353

54-
shellReadTimeout = 2 * time.Minute
55-
shellWriteTimeout = 2 * time.Minute
54+
shellReadTimeout = 3 * time.Minute
55+
shellWriteTimeout = 3 * time.Minute
5656
)
5757

5858
// shellIO allows tests to write input and read output to and from a shell.

0 commit comments

Comments
 (0)