Skip to content

Commit

Permalink
boxcli: increase shell test timeout to 3 mins (#152)
Browse files Browse the repository at this point in the history
This is a workaround for some test runs that are failing due to how long
it takes to install Nix packages. We need to figure out how to cache
these instead.
  • Loading branch information
gcurtis authored Sep 20, 2022
1 parent f829901 commit dfca944
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,10 @@ jobs:
- name: Run tests
run: |
. /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh
go test -v ./...
go test ./...
test-darwin:
if: ${{ false }} # disable until we figure out Homebrew rate limiting
runs-on: macos-12
steps:
- uses: actions/checkout@v3
Expand All @@ -69,6 +70,7 @@ jobs:
HOMEBREW_NO_EMOJI: 1
HOMEBREW_NO_ENV_HINTS: 1
HOMEBREW_NO_INSTALL_CLEANUP: 1
HOMEBREW_GITHUB_API_TOKEN: ${{ github.token }}
run: |
brew update
brew install dash zsh
Expand All @@ -77,4 +79,4 @@ jobs:
- name: Run tests
run: |
. /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh
go test -v ./...
go test ./...
4 changes: 2 additions & 2 deletions boxcli/shell_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ const (
// waiting for a shell prompt.
shellMaxStartupReads = 10_000

shellReadTimeout = 2 * time.Minute
shellWriteTimeout = 2 * time.Minute
shellReadTimeout = 3 * time.Minute
shellWriteTimeout = 3 * time.Minute
)

// shellIO allows tests to write input and read output to and from a shell.
Expand Down

0 comments on commit dfca944

Please sign in to comment.