Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to close persistent notifications #49

Open
fjaguero opened this issue Nov 27, 2017 · 1 comment
Open

Ability to close persistent notifications #49

fjaguero opened this issue Nov 27, 2017 · 1 comment

Comments

@fjaguero
Copy link

Hello and thanks for this great tool. I was wondering if it is expected to add a feature to allow the user to click on an "x" and close a notification? Will a PR for this be accepted?

@jesusoterogomez
Copy link
Owner

jesusoterogomez commented Nov 27, 2017

I have been thinking about this. I'm thinking that an onClick handler on the whole notification makes more sense.

PRs are of course welcome 👍

An x also makes sense. but should be toggable, disabled by default and should probably be an inline SVG icon, since the module doesn't come bundled with any fonts/icons.

Right now, the annoying/hacky way to do it, is by passing JSX markup directly to the show function, and rendering your x icon inside, with an onClick handler attached to the close function.
(Would not recommend to do it this way, but it would in theory solve the need)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants