Skip to content

[1.0] Commit to supporting a specific Rust version #148

Closed
@crumblingstatue

Description

@crumblingstatue
Collaborator

The 1.0 release should guarantee that it builds with a specific Rust version (and later), so new minor versions of our crate don't break when building with the same Rust compiler.

We should also add a Travis test for that specific version in addition to "stable".

Activity

crumblingstatue

crumblingstatue commented on May 9, 2017

@crumblingstatue
CollaboratorAuthor

I would really like to wait for at least associated_consts and pub_restricted in Rust to stabilize before making the commitment.

pub_restricted will most likely be stable in Rust 1.18. I'm not sure about associated_consts.

crumblingstatue

crumblingstatue commented on Jul 12, 2017

@crumblingstatue
CollaboratorAuthor

associated_consts will be stable in 1.20.

I'm setting 1.20 as a target for stabilization.

crumblingstatue

crumblingstatue commented on Sep 7, 2017

@crumblingstatue
CollaboratorAuthor

Hmm... Might want to wait until extern types are stable, as using empty enums for the various Ref types might be unsound.

added this to the 1.0 milestone on Dec 12, 2017
crumblingstatue

crumblingstatue commented on Jan 7, 2018

@crumblingstatue
CollaboratorAuthor

#[repr(transparent)] could also be used to wrap the bindgen generated types instead of declaring separate extern types.

EDIT: repr(transparent) requires non-zero sized types, and bindgen generates a zero-sized type.

I think until extern_types are stable, I'll just copy what bindgen does and put a _unused: [u8; 0] field in these types.

crumblingstatue

crumblingstatue commented on Oct 6, 2024

@crumblingstatue
CollaboratorAuthor

Honestly, most Rust crates just update their MSRV willy-nillly, so I don't see any reason why we should do otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @crumblingstatue

        Issue actions

          [1.0] Commit to supporting a specific Rust version · Issue #148 · jeremyletang/rust-sfml