Skip to content
This repository has been archived by the owner on Nov 21, 2022. It is now read-only.

Sort out colours #720

Open
jenkoian opened this issue Oct 9, 2022 · 6 comments
Open

Sort out colours #720

jenkoian opened this issue Oct 9, 2022 · 6 comments
Assignees

Comments

@jenkoian
Copy link
Owner

jenkoian commented Oct 9, 2022

There are various issues to do with colours of links and what not on the site. Some of these have been patched up, but they aren't really proper fixes. A better fix would be to sort out the colours configured here https://github.com/jenkoian/hacktoberfest-checker/blob/master/tailwind.config.js#L20 and then ensure the appropriate colours are used throughout the site.

I've left the old colours there to see how this was set up last year. Last year we got away with having the same shades of orange that worked for dark and light mode. This year though, we will likely need to provide different colours for light and dark for all aspects. So bare that in mind.

@satyamrs00
Copy link

I want to work on this
would you assign it to me so that i can get started ?

@jenkoian
Copy link
Owner Author

jenkoian commented Oct 9, 2022

@satyamrs00 Sure

@TiwariAbhishek23
Copy link

@jenkoian, sir, I think issue #712 is the same as this one because both depend on the site's colour configuration. Please have a look, I am working on that one.
Thanks

@jenkoian
Copy link
Owner Author

@AbhishekTiwari23 yeah it definitely overlaps

@TiwariAbhishek23
Copy link

TiwariAbhishek23 commented Oct 10, 2022

Hello @jenkoian sir, my setup is ready, and I am looking for some colour suggestions.
I just randomly changed the colour to understand the code. This is not the final.
Thanks
Screenshot 2022-10-10 at 11 58 33 PM

@jenkoian
Copy link
Owner Author

@AbhishekTiwari23 you can see the direction I was going with the colours, please feel free to make suggestions though. I don't hate that screenshot about from the ovals around the links

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants