Come back with the findbug issue - not sure how to do the deep copy

Author: fbelzunc

src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/types/CrowdAuthorizationType.java

@@ -87,11 +87,6 @@ public class CrowdAuthorizationType extends AuthorizationTypeMappingFactory {
      */
     private static final String FILE_NAME = "types/CrowdAuthorizationType/ReverseProxyCrowdSecurityRealm.groovy";
 
-    public void setAuthorities(GrantedAuthority[] authorities) {
-        this.authorities = new GrantedAuthority[0];
-        this.authorities = authorities;
-    }
-
     @DataBoundConstructor
     public CrowdAuthorizationType(String crowdUrl, String crowdApplicationName, String crowdApplicationPassword, int updateInterval) {
         this.crowdUrl = crowdUrl;
@@ -114,22 +109,22 @@ public GrantedAuthority[] retrieveAuthorities(String userFromHeader, HttpServlet
         GrantedAuthority []  storedGrants = authContext.get(userFromHeader);
 
         if (storedGrants != null && storedGrants.length > 1) {
-            setAuthorities(retrieveAuthoritiesIfNecessary(authorityUpdateCache, updateInterval, userFromHeader, storedGrants));
+            authorities = retrieveAuthoritiesIfNecessary(authorityUpdateCache, updateInterval, userFromHeader, storedGrants);
         } else {
             try {
                 UserDetails userDetails = getSecurityRealm().loadUserByUsername(userFromHeader);
-                setAuthorities(userDetails.getAuthorities());
+                authorities = userDetails.getAuthorities();
 
                 Set<GrantedAuthority> tempLocalAuthorities = new HashSet<GrantedAuthority>(Arrays.asList(authorities));
                 tempLocalAuthorities.add(AUTHENTICATED_AUTHORITY);
-                setAuthorities(tempLocalAuthorities.toArray(new GrantedAuthority[0]));
+                authorities = tempLocalAuthorities.toArray(new GrantedAuthority[0]);
 
             } catch (UsernameNotFoundException e) {
                 LOGGER.log(Level.WARNING, "User not found in the Crowd directory: " + e.getMessage());
 
                 Set<GrantedAuthority> tempLocalAuthorities = new HashSet<GrantedAuthority>();
                 tempLocalAuthorities.add(AUTHENTICATED_AUTHORITY);
-                setAuthorities(tempLocalAuthorities.toArray(new GrantedAuthority[0]));
+                authorities = tempLocalAuthorities.toArray(new GrantedAuthority[0]);
             }
         }
         authContext.put(userFromHeader, authorities);

src/main/java/org/jenkinsci/plugins/reverse_proxy_auth/types/LdapAuthorizationType.java

@@ -205,12 +205,6 @@ public String getLDAPURL() {
      */
     public transient GrantedAuthority[] authorities  = new GrantedAuthority[0];
 
-    public void setAuthorities(GrantedAuthority[] authorities) {
-        this.authorities = new GrantedAuthority[0];
-        this.authorities = authorities;
-    }
-
-
     @DataBoundConstructor
     public LdapAuthorizationType(String server, String rootDN, boolean inhibitInferRootDN,
                                  String userSearchBase, String userSearch, String groupSearchBase, String groupSearchFilter, String groupMembershipFilter, String groupNameAttribute, String managerDN, String managerPassword,
@@ -331,22 +325,22 @@ public GrantedAuthority[] retrieveAuthorities(String userFromHeader, HttpServlet
         GrantedAuthority []  storedGrants = authContext.get(userFromHeader);
 
         if (storedGrants != null && storedGrants.length > 1) {
-            setAuthorities(retrieveAuthoritiesIfNecessary(authorityUpdateCache, updateInterval, userFromHeader, storedGrants));
+            authorities = retrieveAuthoritiesIfNecessary(authorityUpdateCache, updateInterval, userFromHeader, storedGrants);
         } else {
             try {
                 LdapUserDetails userDetails = (LdapUserDetails) getSecurityRealm().loadUserByUsername(userFromHeader);
                 authorities = userDetails.getAuthorities();
 
                 Set<GrantedAuthority> tempLocalAuthorities = new HashSet<GrantedAuthority>(Arrays.asList(authorities));
                 tempLocalAuthorities.add(AUTHENTICATED_AUTHORITY);
-                setAuthorities(tempLocalAuthorities.toArray(new GrantedAuthority[0]));
+                authorities = tempLocalAuthorities.toArray(new GrantedAuthority[0]);
 
             } catch (UsernameNotFoundException e) {
                 LOGGER.log(Level.WARNING, "User not found in the LDAP directory: " + e.getMessage());
 
                 Set<GrantedAuthority> tempLocalAuthorities = new HashSet<GrantedAuthority>();
                 tempLocalAuthorities.add(AUTHENTICATED_AUTHORITY);
-                setAuthorities(tempLocalAuthorities.toArray(new GrantedAuthority[0]));
+                authorities = tempLocalAuthorities.toArray(new GrantedAuthority[0]);
             }
         }
         authContext.put(userFromHeader, authorities);