Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip unavailable clouds #341

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AnderwanSAM
Copy link

Fixes #340

Problem resolution :

  1. Catch the exception
  2. Log the exception :
    □ Log level: warning
    □ Message: "Login failure: " + details

Testing :

  1. Three tests
  • Test 1 :
    Two clouds are configured and both are available
    Two jobs
    Expected result: Both jobs are built

  • Test 2 :
    First Cloud down - simulate outage by providing invalid credentials
    Two jobs
    Expected result: Both jobs should be built using the remaining cloud

  • Test 3 :
    Second Cloud down - simulate outage by providing invalid credentials
    Two jobs
    Expected result: Both jobs should be built using the remaining cloud

  1. Adjustments
    □ Made The LoginFailure exception (From JCloudsCloud.java) public so it can be used during the tests
    □ Added (overloaded ) a MockJCloudsCloud constructor to provide clouds with null credentials for the tests
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@AnderwanSAM AnderwanSAM changed the title Fix hanging job jenkins openstack plugin fix: skip unavailable clouds Apr 29, 2022
@AnderwanSAM AnderwanSAM marked this pull request as draft April 29, 2022 18:42
@AnderwanSAM AnderwanSAM marked this pull request as ready for review April 29, 2022 19:01
@AnderwanSAM
Copy link
Author

AnderwanSAM commented Apr 29, 2022

Hello @olivergondza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unavailable cloud stops the provisioning process
1 participant