Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add labels app.kubernetes.io/version and helm.sh/chart #884

Open
psimms-r7 opened this issue Jun 19, 2023 · 2 comments
Open

Add labels app.kubernetes.io/version and helm.sh/chart #884

psimms-r7 opened this issue Jun 19, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@psimms-r7
Copy link

Is your feature request related to a problem? Please describe

Could we add labels app.kubernetes.io/version and helm.sh/chart to stateful set pod

This would allow us to track argocd versions

Describe the solution you'd like

By default add the labels app.kubernetes.io/version and helm.sh/chart to the controller pod in order to track versioning

Describe alternatives you've considered

Adding it ourselves under podLabels:

Additional context

No response
@psimms-r7 psimms-r7 added the enhancement New feature or request label Jun 19, 2023
@NotMyFault
Copy link
Member

Hey,

would you be interested in creating a pull request?

@psimms-r7 psimms-r7 mentioned this issue Jun 19, 2023
Open
@psimms-r7
Copy link
Author

psimms-r7 commented Jun 20, 2023 •
edited
Loading

Hey,

would you be interested in creating a pull request?

Raised pr - #885
Though not sure on the fixes needed for the remaining unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NotMyFault @psimms-r7