Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: support for ENV to filter out PR builds #251

Open
cdaringe opened this issue Oct 10, 2023 · 2 comments
Open

RFC: support for ENV to filter out PR builds #251

cdaringe opened this issue Oct 10, 2023 · 2 comments
Labels
enhancement Improvement or new feature

Comments

@cdaringe
Copy link

What feature do you want to see added?

My job runs builds against commits into the associated branch and PR builds against the associated branch,
but I have no capable filter to remove PR builds.

It would be great to use something like ENV vars (vs just build params):

/buildStatus/icon?job=foo%2Fbar&build=lastCompleted:${env.TRIGGER_BRANCH=main}

such that my PR builds in my job are not used for the badge.

Upstream changes

No response

@cdaringe cdaringe added the enhancement Improvement or new feature label Oct 10, 2023
@cdaringe cdaringe changed the title filter out PR builds RFC: support for ENV to filter out PR builds Oct 10, 2023
@MarkEWaite
Copy link
Contributor

I don't plan to implement this because I believe that a single job that builds multiple branches is confusing for users. It is better to use a multibranch Pipeline and allow the multibranch to create and delete jobs as pull requests arrive and are merged.

@cdaringe
Copy link
Author

Bummer. MultiBranch jenkins isn’t available to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or new feature
Projects
None yet
Development

No branches or pull requests

2 participants