Remove duplicate code #781
Conversation
basil
force-pushed
the
duplicate
branch
2 times, most recently
from
ff6a772
to
a2a4c96
Compare
pom.xml
Outdated
| <artifactId>maven-enforcer-plugin</artifactId> | ||
| <version>${maven-enforcer-plugin.version}</version> |
There was a problem hiding this comment.
Isn't this version already defined in the parent pom, then we do not need it here?
There was a problem hiding this comment.
I am just being consistent with your other code in this POM file that already contains redundant versions. If you think the redundancy should be eliminated, remove it from your existing code in a separate PR and then I will follow suit in this PR.
pom.xml
Outdated
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>${maven-compiler-plugin.version}</version> |
There was a problem hiding this comment.
I am just being consistent with your other code in this POM file that already contains redundant versions. If you think the redundancy should be eliminated, remove it from your existing code in a separate PR and then I will follow suit in this PR.
pom.xml
Outdated
| @@ -226,6 +204,7 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-jar-plugin</artifactId> | |||
| <version>${maven-jar-plugin.version}</version> | |||
There was a problem hiding this comment.
I am just being consistent with your other code in this POM file that already contains redundant versions. If you think the redundancy should be eliminated, remove it from your existing code in a separate PR and then I will follow suit in this PR.
pom.xml
Outdated
| @@ -4,7 +4,7 @@ | |||
| <parent> | |||
| <groupId>org.jenkins-ci.plugins</groupId> | |||
| <artifactId>plugin</artifactId> | |||
| <version>4.69</version> | |||
| <version>4.73</version> | |||
There was a problem hiding this comment.
Unrelated change already part of dependabot.
There was a problem hiding this comment.
But you haven't merged it, yet? So as long as trunk doesn't contain it, it is a valid change.
|
I am denying the request for changes, for the reasons explained above. |
As of the latest plugin parent POM, the properties are already defined in the plugin parent POM and the BOMs are already imported, so these code is duplicate and can be safely deleted.