feat(vpc): simplify network with one gw per subnet with one ip per gw

Author: smerle33

vpc.tf

@@ -1,16 +1,10 @@
-resource "aws_eip" "nat_eip" {
-  count  = 2
-  domain = "vpc"
-}
-
 module "vpc" {
   source  = "terraform-aws-modules/vpc/aws"
   version = "5.13.0"
 
   name = "${local.cluster_name}-vpc"
   cidr = "10.0.0.0/16" # cannot be less then /16 (more ips)
 
-
   # dual stack https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/v5.13.0/examples/ipv6-dualstack/main.tf
   enable_ipv6                                   = true
   public_subnet_assign_ipv6_address_on_creation = true
@@ -32,8 +26,7 @@ module "vpc" {
     # next for eks agents
     "10.0.4.0/23", # 10.0.4.1 -> 10.0.5.254 (510 ips)
   ]
-  public_subnets = [ # need at least one for the module (line 1085 : subnet_id = element(aws_subnet.public[*].id,var.single_nat_gateway ? 0 : count.index,))
-    #fake one
+  public_subnets = [ # need at least one public network to host the NAT gateways
     "10.0.255.0/24", # 10.0.255.1 -> 10.0.255.254 (254 ips)
   ]
 
@@ -46,19 +39,7 @@ module "vpc" {
   enable_nat_gateway     = true
   single_nat_gateway     = false
   one_nat_gateway_per_az = false
-  ###### I cannot find a way to set a multiple IP for outgoing GW ... the count is not working
-  ###### https://registry.terraform.io/modules/terraform-aws-modules/vpc/aws/latest#external-nat-gateway-ips
-  ######
-  ######  https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/nat_gateway
-  ######
-  reuse_nat_ips       = true                 # <= Skip creation of EIPs for the NAT Gateways
-  external_nat_ip_ids = aws_eip.nat_eip.*.id # <= IPs specified here as input to the module
-  ###### I may have to create those aws_eip with name nat manually
 
   enable_dns_hostnames = true
 
-  public_subnet_tags = {
-    "kubernetes.io/role/internal-elb" = 1 ###TODO CHECK
-  }
-
 }